objspace_dump.c: skip dumping method name if not pure ASCII #6161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidekiq has a method named `❨╯°□°❩╯︵┻━┻`which corrupts heap dumps. Normally we could just dump is as is since it's valid UTF-8 and need no escaping. But our code to escape control characters isn't UTF-8 aware so it's more complicated than it seems. Ultimately since the overwhelming majority of method names are pure ASCII, it's not a big loss to just skip it.
casperisfine
pushed a commit
to casperisfine/sidekiq
that referenced
this pull request
Jul 21, 2022
Ruby heap dump has a bug in which it generates invalid JSON when a method name is non-ASCII: ruby/ruby#6161 It's certainly not Sidekiq's fault, but I think it may be worth working around it to avoid confusing people trying to debug memory issues.
casperisfine
pushed a commit
to casperisfine/sidekiq
that referenced
this pull request
Jul 21, 2022
Ruby heap dump has a bug in which it generates invalid JSON when a method name is non-ASCII: ruby/ruby#6161 It's certainly not Sidekiq's fault, but I think it may be worth working around it to avoid confusing people trying to debug memory issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sidekiq has a method named
❨╯°□°❩╯︵┻━┻which corrupts heap dumps.Normally we could just dump is as is since it's valid UTF-8 and need no escaping. But our code to escape control characters isn't UTF-8 aware so it's more complicated than it seems.
Ultimately since the overwhelming majority of method names are pure ASCII, it's not a big loss to just skip it.
cc @vahe