Better offsets #6315
Merged
Better offsets #6315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddnewton
requested review from
maximecb,
XrXr,
tenderlove and
k0kubun
as code owners
maximecb
reviewed
Sep 2, 2022
maximecb
reviewed
Sep 2, 2022
kddnewton
force-pushed
the
better-offsets
branch
from
4b726cc
to
cf3561b
Compare
There are a lot of instructions on AArch64 where we take an offset from PC in terms of the number of instructions. This is for loading a value relative to the PC or for jumping. We were usually accepting an A64Opnd or an i32. It can get confusing and inconsistent though because sometimes you would divide by 4 to get the number of instructions or multiply by 4 to get the number of bytes. This commit adds a struct that wraps an i32 in order to keep all of that logic in one place. It makes it much easier to read and reason about how these offsets are getting used.
kddnewton
force-pushed
the
better-offsets
branch
from
acbd866
to
fc7bdbc
Compare
|
Ah, this looks like it might be related to the ARM64 crash. I'll check if it's better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits in this one. The first consolidates how we handle instruction offsets. The second uses a
binstruction when the offset fits for theJmpinstruction. More detailed descriptions in the commits.