Don't define ruby_qsort when POSIX qsort_r is available. #6332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code would define
ruby_qsort
as a wrapper ofqsort_s
when it is available. When bothqsort_s
and POSIX (GNU)qsort_r
are available, we should callqsort_r
directly instead, and theqsort_s
wrapper is redundant.This fixes ruby build on FreeBSD with
qsort_r
interface modified to match POSIX one (more information at https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266227 and http://gohan05.nyi.freebsd.org/data/mainamd64PR266227-default/2022-09-06_09h13m56s/logs/errors/ruby32-3.2.0.p1_2,1.log ).