uri/generic: Support comma-delimited rules in no_proxy #6424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `URI::Generic.use_proxy?` did not treat the `no_proxy` variable as a comma-delimited string. That means that it's not possible to specify multiple rules, such as: ``` no_proxy=.example.com,192.168.0.0/8 ``` While there's no official standard for `no_proxy`, the comma is parsed in other languages such as Python and Go. https://bugs.ruby-lang.org/issues/19018
stanhu
commented
Sep 23, 2022
| no_proxy.split(',').each do |name| | ||
| name.strip! | ||
|
|
||
| name.scan(/([^:,\s]+)(?::(\d+))?/) {|p_host, p_port| |
There was a problem hiding this comment.
Hmm, what's this comma doing here? Oh, I see--it is trying to parse multiple hostnames here.
|
I think this should be sent to upstream: https://github.com/ruby/uri |
|
I'm going to close this because it turns out this change is not needed. Maybe the test cases should be included, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
URI::Generic.use_proxy?did not treat theno_proxyvariable as a comma-delimited string. That means that it's not possible to specify multiple rules, such as:While there's no official standard for
no_proxy, the comma is parsed in other languages such as Python and Go.https://bugs.ruby-lang.org/issues/19018