Improvements to IO::Buffer implementation and documentation. #6525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobu
reviewed
Oct 11, 2022
nobu
reviewed
Oct 11, 2022
ioquatix
force-pushed
the
io-buffer-offsets
branch
from
2f72b71
to
ce5bf7b
Compare
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
ioquatix
force-pushed
the
io-buffer-offsets
branch
from
15f55c8
to
2bbabb0
Compare
aalin
added a commit
to aalin/fiber_scheduler
that referenced
this pull request
Dec 28, 2022
This makes fiber_scheduler work with Ruby 3.2.0 The offset argument was added in ruby/ruby#6525 Related changes in the async gem: socketry/async@a932d6a socketry/async@c6c7393
kudojp
added a commit
to kudojp/ruby
that referenced
this pull request
Sep 8, 2023
* Each of Fiber::Scheduler#io_read and io_write takes the "offset" as the fourth argument, which is not doucmented. * This change was introduced in ruby#6525 and shipped as Ruby 3.2. This should be documented in NEWS-3.2.0.md. Add Fiber::Scheduler#io_read|write arguments change to NEWS-3.2.0
kudojp
added a commit
to kudojp/ruby
that referenced
this pull request
Sep 8, 2023
* Each of Fiber::Scheduler#io_read and io_write takes the "offset" as the fourth argument, which is not doucmented. * This change was introduced in ruby#6525 and shipped as Ruby 3.2. This should be documented in NEWS-3.2.0.md. Add Fiber::Scheduler#io_read|write arguments change to NEWS-3.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.