New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes more clippy warnings #6543
Conversation
Messed up the macro change. Going to revert that one. It was the most iffy of them all. Edit: Actually just missed the x86 version. Fixing |
@@ -96,6 +96,7 @@ pub type size_t = u64; | |||
pub type RedefinitionFlag = u32; | |||
|
|||
#[allow(dead_code)] | |||
#[allow(clippy::useless_transmute)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol
@@ -122,12 +122,20 @@ yjit_print_iseq(const rb_iseq_t *iseq) | |||
|
|||
#[cfg(target_arch = "aarch64")] | |||
macro_rules! c_callable { | |||
(fn $f:ident $args:tt $(-> $ret:ty)? $body:block) => { extern "C" fn $f $args $(-> $ret)? $body }; | |||
($(#[$outer:meta])* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's outer:meta ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doc comments outside of functions like ///
are actually sugar for meta attributes like #[doc="..."]
and this is how you'd match against them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
No description provided.