[DOC] More about line number #6582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doc/io_streams.rdoc
Outdated
Comment on lines
367
to
372
| The line number is the number of lines read by certain line-oriented methods | ||
| (+each_line+, +foreach+, +gets+, +readline+, and +readlines+), | ||
| not the number of newlines read; the two numbers: | ||
|
|
||
| - Will be the same if those methods are called only with the default line separator. | ||
| - May differ if any is called with a non-default line separator. |
There was a problem hiding this comment.
I feel like this is a bit redundant. The line number is the number of linebreaks encountered however you define a newline, which could be \n, \r\n, or something else.
There was a problem hiding this comment.
Recast. B/c we now mention argument +sep+, I've linked to the methods.
doc/io_streams.rdoc
Outdated
Comment on lines
374
to
375
| A new stream is initially has line number zero, | ||
| and method +rewind+ resets the line number to zero. |
There was a problem hiding this comment.
This makes it sound like all rewind does is reset the lineno (when in reality, resetting the lineno is more of a side effect of rewind).
peterzhu2118
approved these changes
Oct 19, 2022
tenderlove
pushed a commit
to Shopify/ruby
that referenced
this pull request
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds info about when line number changes; also suppresses a few unwanted autolinks in file.c.