Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exit locations dump #6703

Merged
merged 1 commit into from Nov 9, 2022
Merged

Fix exit locations dump #6703

merged 1 commit into from Nov 9, 2022

Commits on Nov 9, 2022

  1. Fix exit locations dump 

    While I was working on my RubyConf talk for tracing yjit exit locations
I realized that there were exits from the dump code included in the
stats data. For example I saw 224 interp leave exits for a simple script
that should have had 1 or 2. I realized that the dump code needs to be
called _after_ the stats are generated, otherwise the dump code will be
counted in the stats exits.

I've added a `_dump_locations` method to the `at_exit` for stats
generation to ensure that it runs last. I've updated the documentation
to add a note that if you call `dump_exit_locations` directly, your
stats will include the dump code exits as well.
    @eileencodes
    eileencodes committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    f9fdadc View commit details
    Browse the repository at this point in the history