YJIT: Stop wrapping CmePtr with CmeDependency #6747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XrXr
approved these changes
Nov 16, 2022
yjit/src/core.rs
Outdated
Comment on lines
372
to
373
| // In case this block is invalidated, these two pieces of info | ||
| // help to remove all pointers to this block in the system. |
There was a problem hiding this comment.
Oops, didn't catch that this comment is outdated now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up refactoring after #6734. This reduces memory consumption by only 0.1MB, so I wasn't sure if I should file this, but I filed this anyway because the code becomes slightly simpler.