Adding scalar Addition and Substraction #685
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this to add some more code |
|
I think that adding this feature is a net loss. We are losing the error message, which is the expected vanila behavior. The feature should be published as a gem, and not forced onto everyone by adding it to the core. |
matzbot
pushed a commit
that referenced
this pull request
Aug 29, 2023
(ruby/irb#691) They were removed in #685, but we should still keep them to avoid breaking changes to tools like Chef. https://github.com/chef/chef/blob/533ff089479763f29045e4e6ddf388b73fc99338/lib/chef/shell.rb#L138 ruby/irb@b585e0c835
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Matrix class supports scalar (real number) multiplication, division and exponentiation, e.g.
5 * Matrix[ [25, 93], [-1, 66] ]. This PR adds scalar addition and subtraction, which is supported by major scientific tools including Matlab, Octave and Python (numpy).