[Bug #19259] Data#with should call initialize method
#7031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zverok
reviewed
Dec 26, 2022
| @@ -215,6 +215,20 @@ def test_with | |||
| assert_raise_with_message(ArgumentError, "wrong number of arguments (given 1, expected 0)") do | |||
| source.with({ bar: 2 }) | |||
| end | |||
|
|
|||
| oddclass = Data.define(:odd) do | |||
There was a problem hiding this comment.
Can you please add a structuring comment like "Testing #initialize is called" or something? The rest of the method has brief structuring, and I believe it is helpful for maintainers.
There was a problem hiding this comment.
Rather I'd prefer splitting this test method per the comments later.
There was a problem hiding this comment.
Or this 🤷
(Honestly, I miss RSpec's nesting. It might become unhinged sometimes, but at least describe '#initialize with nested examples and contexts really helps with reading and running tests.)
zverok
approved these changes
Jan 21, 2023
nobu
force-pushed
the
data_with-call-initialize
branch
from
0b289eb
to
45f0e3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.