Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YJIT: Remove old comments for regenerated branches #7083

Merged
merged 1 commit into from Jan 9, 2023
Merged

YJIT: Remove old comments for regenerated branches #7083

merged 1 commit into from Jan 9, 2023

Conversation

k0kubun
Copy link
Member

@k0kubun k0kubun commented Jan 7, 2023

I see some comment duplication when the same address is compiled twice. It seems useful to not see the same comment twice.

Before

  # opt_plus
  # regenerate_branch
  # Block: a@/home/k0kubun/tmp/comments.rb:2 (ISEQ offset: 3)
  # opt_plus
  0x55d91c106068: mov rax, qword ptr [rbx]

After

  # regenerate_branch
  # Block: a@/home/k0kubun/tmp/comments.rb:2 (ISEQ offset: 3)
  # opt_plus
  0x55f04c985068: mov rax, qword ptr [rbx]

@matzbot matzbot requested a review from a team January 7, 2023 00:07
@maximecb maximecb merged commit a7fbdc3 into ruby:master Jan 9, 2023
@k0kubun k0kubun deleted the yjit-remove-comments branch January 9, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahgibbs noahgibbs noahgibbs approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@k0kubun @noahgibbs @maximecb