Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YJIT: Do not refer to an undefined constant #7112

Merged
merged 1 commit into from Jan 12, 2023
Merged

YJIT: Do not refer to an undefined constant #7112

merged 1 commit into from Jan 12, 2023

Conversation

k0kubun
Copy link
Member

@k0kubun k0kubun commented Jan 12, 2023

Qnil is not defined under RubyVM::YJIT. It was introduced in f90549c, but it seems not intentional. I guess you didn't mean Fiddle::Qnil either. You probably wanted to do Primitive.cexpr! 'Qnil', but nil is enough if that's the case.

@matzbot matzbot requested a review from a team January 12, 2023 17:42
@maximecb maximecb merged commit da7e5c7 into ruby:master Jan 12, 2023
@maximecb maximecb deleted the yjit-qnil branch January 12, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahgibbs noahgibbs noahgibbs approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@k0kubun @noahgibbs @maximecb