Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YJIT: log the names of methods we call to in disasm #7231

Merged
merged 3 commits into from Feb 2, 2023
Merged

YJIT: log the names of methods we call to in disasm #7231

merged 3 commits into from Feb 2, 2023

Conversation

maximecb
Copy link
Contributor

@maximecb maximecb commented Feb 2, 2023

Makes it easier to make sense of disasm and spot optimization opportunities. Could also help with debugging.

@maximecb maximecb requested review from XrXr and k0kubun February 2, 2023 18:56
@matzbot matzbot requested a review from a team February 2, 2023 18:56
k0kubun
k0kubun approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@k0kubun k0kubun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 When the receiver is a class or a module, we might want to do it differently (i.e. show Foo.bar instead of Class#bar or Module#bar), but better than having nothing for that case too.

@XrXr
Copy link
Member

XrXr commented Feb 2, 2023

Yeah, rb_class2name() can return NULL

@maximecb maximecb merged commit 73674ca into ruby:master Feb 2, 2023
@maximecb maximecb deleted the yjit_log_method branch February 2, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k0kubun k0kubun k0kubun approved these changes

@XrXr XrXr Awaiting requested review from XrXr

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@maximecb @XrXr @k0kubun