YJIT: Support arg0 splat on invokeblock #7234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0kubun
force-pushed
the
yjit-arg0-splat
branch
9 times, most recently
from
7c0bd09
to
47116e6
Compare
k0kubun
force-pushed
the
yjit-arg0-splat
branch
from
47116e6
to
e89cd62
Compare
k0kubun
added a commit
that referenced
this pull request
Feb 14, 2023
I added `invokeblock_iseq_arg0_args_splat` counter but it wasn't used because of a typo. Related to #7234
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #7233,
iseq_arg0_splatis now the largest exit reason (95.2% of invokeblock exit reasons) when you rewrite Array#each in Ruby. This PR fixes that for the most common case.railsbench stats
Even without Array#each in Ruby, it does seem to show a small improvement in the number of side exits: (using run_once.sh)
before
after