Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we started to discuss how we compress
Context
, I'd like to add stats about its size.Through these metrics, I'd like to remind us that memory consumed by
Context
is currently not that dominant, but these stats will also be useful to notice it's getting more important as we add more fields to it.Current stats
Current YJIT stats with stats build on railsbench 25 itrs:
Implementation design
I considered incrementing or decrementing the counter as it gets allocated or deallocated, but it seemed rather complicated. Scanning all at the end seems to make the implementation simple and precise. However, because it comes at the cost of scanning all payloads, these metrics are available only at exit by default.