YJIT: Use rb_ivar_get at the end of ivar chains #7334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0kubun
force-pushed
the
yjit-chain-end
branch
from
6832cc8
to
ab11450
Compare
maximecb
reviewed
Feb 17, 2023
maximecb
approved these changes
Feb 17, 2023
casperisfine
pushed a commit
to Shopify/ruby
that referenced
this pull request
May 25, 2023
* YJIT: Use rb_ivar_get at the end of ivar chains * Rename the counter to get_ivar_max_depth
jhawthorn
pushed a commit
to github/ruby
that referenced
this pull request
Sep 8, 2023
* YJIT: Use rb_ivar_get at the end of ivar chains * Rename the counter to get_ivar_max_depth
casperisfine
pushed a commit
to Shopify/ruby
that referenced
this pull request
Sep 20, 2023
* YJIT: Use rb_ivar_get at the end of ivar chains * Rename the counter to get_ivar_max_depth
jhawthorn
pushed a commit
to github/ruby
that referenced
this pull request
Sep 28, 2023
* YJIT: Use rb_ivar_get at the end of ivar chains * Rename the counter to get_ivar_max_depth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #7298, this PR adds a
rb_ivar_getcall at the end of a getivar chain.getivar_megamorphicis currently the largest exit reason of SFR, and this change should address it.