Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YJIT: Avoid checking symbol ID twice on send #7350

Merged
merged 1 commit into from Feb 21, 2023
Merged

YJIT: Avoid checking symbol ID twice on send #7350

merged 1 commit into from Feb 21, 2023

Conversation

k0kubun
Copy link
Member

@k0kubun k0kubun commented Feb 21, 2023 •
edited

If I read this correctly, this place is checking mid <= 0, but ID is unsigned, and mid != 0 case seems doubly guarded by the subsequent chain guard because we have return CantCompile under if mid == 0 {. This doesn't seem necessary.

@k0kubun k0kubun marked this pull request as ready for review February 21, 2023 21:07
@matzbot matzbot requested a review from a team February 21, 2023 21:07
@maximecb maximecb merged commit 0353277 into ruby:master Feb 21, 2023
@k0kubun k0kubun deleted the yjit-symbol-check branch February 21, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@k0kubun @maximecb