YJIT: Bump SEND_MAX_DEPTH to 10 #7452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like perf improved quite a bit as well, 12 => 13-14% speedup on SFR. Would be curious how this affects total memory usage. Also curious what happens if we bump it all the way to 16. I would expect that there's a long tail of classes seen at call sites that follow a pareto distribution. If that's correct, then a bit more increase might again cut the number of side-exits by half. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On SFR, this reduced
send_klass_megamorphic / side_exit_countfrom 20.5% to 15.0%.send_klass_megamorphicis not that common on railsbench, so it had no significant impact there.