Correctly clean up keeping_mutexes before resuming any other threads.
#7460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible (but very rare) to have a race condition between setting `mutex->fiber = NULL` and `thread_mutex_remove(th, mutex)` which results in the following bug: ``` [BUG] invalid keeping_mutexes: Attempt to unlock a mutex which is not locked ``` Fixes <https://bugs.ruby-lang.org/issues/19480>.
ioquatix
force-pushed
the
thread-mutex-unlock-fixes
branch
from
7d9ddb7
to
d452712
Compare
ioquatix
added a commit
to socketry/async
that referenced
this pull request
Mar 7, 2023
See <ruby/ruby#7460> for more details.
ioquatix
added a commit
to socketry/async
that referenced
this pull request
Mar 7, 2023
See <ruby/ruby#7460> for more details.
ioquatix
added a commit
to socketry/async
that referenced
this pull request
Mar 7, 2023
See <ruby/ruby#7460> for more details.
ioquatix
added a commit
to socketry/async
that referenced
this pull request
Mar 7, 2023
See <ruby/ruby#7460> for more details.
ioquatix
added a commit
to socketry/async
that referenced
this pull request
Mar 7, 2023
See <ruby/ruby#7460> for more details.
ioquatix
added a commit
to socketry/async
that referenced
this pull request
Mar 7, 2023
…`. (#216) See <ruby/ruby#7460> for more details.
ioquatix
added a commit
to socketry/async
that referenced
this pull request
Mar 7, 2023
…`. (#216) See <ruby/ruby#7460> for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible (but very rare) to have a race condition between setting
mutex->fiber = NULLandthread_mutex_remove(th, mutex)which results in the following bug:Fixes https://bugs.ruby-lang.org/issues/19480.