New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YJIT: upgrade type in `guard_object_is_string` #7489

Merged

maximecb merged 3 commits into ruby:master from Shopify:yjit_guard_string

Mar 9, 2023

Contributor

maximecb commented Mar 9, 2023

Also make logic more in line with other guard_xxx methods


          YJIT: upgrade type in guard_object_is_string

d99ff04

Also make logic more in line with other guard_xxx methods

matzbot requested a review from a team

March 9, 2023 21:56

maximecb commented

View reviewed changes

yjit/src/core.rs Outdated Show resolved Hide resolved

maximecb and others added 2 commits

March 9, 2023 16:56


          Update yjit/src/core.rs

6491a6b


          Revert changes to Type::upgrade()

ab0eb8d

This was referenced Mar 9, 2023

YJIT: use Context in guard_object_is methods #7056

Closed

YJIT: all guard methods should update context's type info Shopify/ruby#460

Closed

noahgibbs approved these changes

View reviewed changes

k0kubun approved these changes

View reviewed changes

maximecb merged commit 65a95b8 into ruby:master

97 checks passed

maximecb deleted the yjit_guard_string branch

March 9, 2023 23:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment