New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YJIT: Introduce no_gc attribute #7511
Conversation
It's relevant for allocation tracing, and we've seen that not updating PC can cause SEGV with stackprof. Also, since GC contends for the VM lock, another thread might have triggered global invalidation while it's waiting. In which case we need the patch point recording in By the way, allocation implies raising because of |
Ah, I see. I'll keep the original By the way, this means that we should fix #7466 too. We paired on this during your vacation, I wrote
I discussed this on ruby-lang Slack before. Koichi's take was that |
Alas, CI notices |
I added this to |
b5619be
to
b510bf8
Compare
to see if it stabilizes Cirrus CI.
This reverts commit f613c18.
no_gc
attribute to skip thatjit_prepare_routine_call
when possiblejit_prepare_routine_call
.Kernel#class
is one of such methods that are called often on railsbench Shopify/yjit-bench#168.