YJIT: Rest and block_arg support #7584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The message "Revert "Revert ... feels very silly to me. |
jimmyhmiller
force-pushed
the
yjit-restore-rest-and-block-support
branch
from
e9fa3db
to
4487012
Compare
jimmyhmiller
changed the title
|
@nobu Sorry that was just the default title from running git revert. Just changed it back to the original title of the original PR. |
maximecb
approved these changes
Mar 23, 2023
jimmyhmiller
force-pushed
the
yjit-restore-rest-and-block-support
branch
from
4487012
to
c4ff415
Compare
jimmyhmiller
force-pushed
the
yjit-restore-rest-and-block-support
branch
from
c4ff415
to
1520091
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 30e7561.
#7557 was originally reverted because it was believed to be the cause of the sequel benchmark failing. The underlying issue was actually fixed in #7575