Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This codegen simply skips pushing a frame when calling
Array#<<
. The interpreter skips it onopt_ltlt
, so it's fair to do the same thing on YJIT.Note that we cannot use
Primitive.attr! :leaf
to implement this because BOP methods must be implemented in C at the moment.Benchmark
I found this is useful for speeding up Optcarrot when I worked on RJIT. This doesn't speed up headline benchmarks, but this method should be fairly popular in actual real-world applications.