Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YJIT: Avoid using a register for unspecified_bits #7685

Merged
merged 1 commit into from Apr 10, 2023
Merged

YJIT: Avoid using a register for unspecified_bits #7685

merged 1 commit into from Apr 10, 2023

Conversation

k0kubun
Copy link
Member

@k0kubun k0kubun commented Apr 10, 2023

Fix [Bug #19586]

Because unspec_opnd uses a slot above the stack top, calling ctx.spill_temps later did not spill unspec_opnd as expected. This PR makes sure the register bit for unspec_opnd is unset by this ctx.spill_temps.

@matzbot matzbot requested a review from a team April 10, 2023 22:41
XrXr
XrXr approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@XrXr XrXr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comprehensive diagnosis and test! Interesting case of how things get a bit weird around argument transfer. Glad that we got a report from yahonda.

@k0kubun k0kubun merged commit 1ff14a8 into ruby:master Apr 10, 2023
98 checks passed
@k0kubun k0kubun deleted the yjit-unspec-bits branch April 10, 2023 23:35
@nobu nobu mentioned this pull request Apr 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XrXr XrXr XrXr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@k0kubun @XrXr