Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YJIT: Move stack_opnd from Context to Assembler #7700

Merged
merged 1 commit into from Apr 13, 2023
Merged

YJIT: Move stack_opnd from Context to Assembler #7700

merged 1 commit into from Apr 13, 2023

Conversation

k0kubun
Copy link
Member

@k0kubun k0kubun commented Apr 12, 2023

Following up #7691, this PR moves the ctx.stack_opnd method to Assembler.

I'm thinking about reloading a stack temp on stack_opnd and stack_pop, so using Assembler as a receiver to modify its state would be useful later. I also moved stack_pop and shift_stack that rely on stack_opnd to Assembler too.

@matzbot matzbot requested a review from a team April 12, 2023 21:12
@maximecb maximecb merged commit 2fcd3ea into ruby:master Apr 13, 2023
98 checks passed
@maximecb maximecb deleted the yjit-stack-opnd branch April 13, 2023 16:20
@k0kubun k0kubun mentioned this pull request Apr 13, 2023
Merged
@nobu nobu mentioned this pull request Apr 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@k0kubun @maximecb