YJIT: Avoid splitting mov for small values on arm64 #7745
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
Mov
's destination is a register and the source is an immediate which cannot be encoded with a bitmask but is <=0xffff
, it can be a singlemov
instruction.Currently,
split_bitmask_immediate
splits such source operands, which are still necessary for other instructions, so this PR avoids calling it for that case.While I don't see a significant impact on benchmarks, this should help the performance of stack temp register allocation on arm64 #7659 a little.
Example
before
after