Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YJIT: Show definedivar exit reasons #7755

Merged
merged 1 commit into from Apr 24, 2023
Merged

YJIT: Show definedivar exit reasons #7755

merged 1 commit into from Apr 24, 2023

Conversation

k0kubun
Copy link
Member

@k0kubun k0kubun commented Apr 24, 2023

definedivar makes up 4.3% of exit reasons on SFR. It'd be nice to show a breakdown of it.

I bet it's mostly definedivar_megamorphic and we want to put a general case at the end of chains, but I want to double-check it first.

@matzbot matzbot requested a review from a team April 24, 2023 17:14
maximecb
maximecb approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@maximecb maximecb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wise to gather more data 👌

@k0kubun k0kubun mentioned this pull request Apr 24, 2023
Merged
@k0kubun k0kubun merged commit f84d94b into ruby:master Apr 24, 2023
98 checks passed
@k0kubun k0kubun deleted the yjit-definedivar branch April 24, 2023 19:20
@nobu nobu mentioned this pull request Apr 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximecb maximecb maximecb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@k0kubun @maximecb