Use the rb_sys_fail_str macro in signal.c #7812
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let signal.c include
"internal/error.h"
explicitly to ensure that the identifierrb_sys_fail_str
insignal.c
refers to the macro defined in"internal/error.h"
instead of the actual function.That macro reads
errno
before evaluating its argument. Without this change, therb_signo2signm(sig)
expression in thetrap
function insignal.c
will overwrite theerrno
before the actualrb_sys_fail_str
function reads theerrno
.Fixes: https://bugs.ruby-lang.org/issues/19635