Fix mutation on shared strings. #7837

ioquatix · 2023-05-22T03:30:26Z

Fixes https://bugs.ruby-lang.org/issues/19084.

Relates to #6630.

When creating a mutable buffer backed by a string, ensure that rb_str_modify is invoked to detach any shared state. Otherwise, mutation can accidentally modify other strings if they are shared.

Thanks to @jemmaissroff for finding this issue.

Fix mutation on shared strings. (#7837) --- io_buffer.c | 19 ++++++++++++------- test/ruby/test_io_buffer.rb | 4 ---- 2 files changed, 12 insertions(+), 11 deletions(-)

Fix mutation on shared strings.

1356160

ioquatix merged commit bd786e7 into ruby:master May 22, 2023
90 of 95 checks passed

ioquatix deleted the io-buffer-rename-data-buffer branch May 22, 2023 03:58

matzbot pushed a commit that referenced this pull request Jul 16, 2023

merge revision(s) bd786e7: [Backport #19084]

c911cbd

Fix mutation on shared strings. (#7837) --- io_buffer.c | 19 ++++++++++++------- test/ruby/test_io_buffer.rb | 4 ---- 2 files changed, 12 insertions(+), 11 deletions(-)

matzbot pushed a commit that referenced this pull request Jul 25, 2023

merge revision(s) bd786e7: [Backport #19084]

3799270

Fix mutation on shared strings. (#7837) --- io_buffer.c | 19 ++++++++++++------- test/ruby/test_io_buffer.rb | 4 ---- 2 files changed, 12 insertions(+), 11 deletions(-)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix mutation on shared strings. #7837

Fix mutation on shared strings. #7837

ioquatix commented May 22, 2023 •

edited

Fix mutation on shared strings. #7837

Fix mutation on shared strings. #7837

Conversation

ioquatix commented May 22, 2023 • edited

ioquatix commented May 22, 2023 •

edited