Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing_ruby.md: Update make test-all tips [ci skip] #7861

Merged
merged 1 commit into from
May 26, 2023
Merged

testing_ruby.md: Update make test-all tips [ci skip] #7861

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion doc/contributing/testing_ruby.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ We can run any of the make scripts [in parallel](building_ruby.md#label-Running+
first the file name, and then the test name, prefixed with `--name`. For example:

```
make test-all TESTS="../test/ruby/test_alias.rb --name=/test_alias_with_zsuper_method/"
make test-all TESTS="../test/ruby/test_alias.rb --name=TestAlias#test_alias_with_zsuper_method"
```

To run these specs with logs, we can use:
Expand All @@ -79,6 +79,12 @@ We can run any of the make scripts [in parallel](building_ruby.md#label-Running+
make test-all TESTS=-v
```

We can display the help of the `TESTS` option:

```
$ make test-all TESTS=--help
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also ruby test/runner.rb --help can, if your ruby is 2.7 or later.

Copy link
Member Author

@junaruga junaruga May 26, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info. Do you have an idea about how to add the ruby test/runner.rb --help to this document?

Like this? Or you just introduced the way here. And you think we don't need to add the ruby test/runner.rb --help to the document? I suppose that adding the runtime ruby version requires 2.7 or later is a bit too detailed.

diff --git a/doc/contributing/testing_ruby.md b/doc/contributing/testing_ruby.md
index 167ab55c55..1289cd4341 100644
--- a/doc/contributing/testing_ruby.md
+++ b/doc/contributing/testing_ruby.md
@@ -85,6 +85,12 @@ We can run any of the make scripts [in parallel](building_ruby.md#label-Running+
     $ make test-all TESTS=--help
     ```
 
+    We can also display the help with
+
+    ```
+    $ ruby test/runner.rb --help
+    ```
+
     If we would like to run both the `test/` and `bootstraptest/` test suites, we can run
 
     ```


If we would like to run both the `test/` and `bootstraptest/` test suites, we can run

```
Expand Down