Remove taint and untrusted flags #7958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These flags do nothing already, and should break nothing.
These macros had been defined to use with `#ifdef`, but should not be used anymore.
ioquatix
approved these changes
Jun 19, 2023
ioquatix
reviewed
Jun 20, 2023
| #define RB_OBJ_TAINTABLE RB_OBJ_TAINTABLE | ||
| #define RB_OBJ_TAINTED RB_OBJ_TAINTED | ||
| #define RB_OBJ_TAINTED_RAW RB_OBJ_TAINTED_RAW | ||
| #define RB_OBJ_TAINT_RAW RB_OBJ_TAINT_RAW | ||
| #define RB_OBJ_UNTRUST RB_OBJ_TAINT |
There was a problem hiding this comment.
@nobu should we also remove RB_OBJ_UNTRUST and RB_OBJ_UNTRUSTED?
There was a problem hiding this comment.
These 2 replace different names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FL_TAINT and FL_UNTRUSTED flags have been deprecated and warned since 3.1.
Try to make then 0 as the first step.