New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mirror ruby/yarp into ruby/ruby #7964
Conversation
5fdbe8f
to
9b77eec
Compare
The changes look good to me. Could you include
In terms of features added to CRuby, are the following features what this PR is adding?
Are the both files upgradable by installing yarp.gem? My general understanding is that it would require the standard library to be gemified, but I wonder there's any trick that you used inside Also, since it's not clarified in https://bugs.ruby-lang.org/issues/19741, could we clarify the next steps that you're going to work on before Ruby 3.3 release? In particular, I'm interested in whether you plan to do the following stuff or not:
(I'm not requesting them for 3.3 but just curious about the timeline) |
The default gems sync script now includes YARP, found in the ruby/yarp repo. This script primarily syncs over the src, test, lib directories. It also migrates all encoding files to be prefixed with `yp_` in order to deconflict from existing encoding files.
Add yarp to common.mk and windows builds to enable us to run yarp correctly with CI.
Init_YARP is called from inits.c, and it loads the YARP C extension correctly
This commit is the initial sync of all files from ruby/yarp into ruby/ruby. Notably, it does the following: * Sync all ruby/yarp/lib/ files to ruby/ruby/lib/yarp * Sync all ruby/yarp/src/ files to ruby/ruby/yarp/ * Sync all ruby/yarp/test/ files to ruby/ruby/test/yarp
9b77eec
to
6876f85
Compare
Yes!
We haven't looked into this in detail yet, but we'd like to enable upgrading of yarp.gem independent of the Ruby release schedule. We will figure this out before the Ruby 3.3 release.
Yes, we will do this after merging this PR!
Yes, this will require more work to integrate YARP's AST with the compiler. I plan to work on this after merging this PR.
We haven't made a decision about this yet. |
This PR accomplishes the following:
tool/sync_default_gems.rb
sync script