ruby_3_2 backport for #8006 #8008
Conversation
When passing an array as the sole argument to `yield`, and the yieldee takes more than 1 optional parameter, the array is expanded similar to `*array` splat calls. This is called "autosplat" in `setup_parameters_complex()`. Previously, YJIT did not detect this autosplat condition. It passed the array without expanding it, deviating from interpreter behavior. Detect this conditon and refuse to compile it.
XrXr
force-pushed
the
yjit-32-autosplat-opts
branch
from
303700a
to
8e1053b
Compare
|
Everything passed except for something which seems to be a Cirrus CI issue, so I'm going to merge this. |
|
Sorry, I forgot to mention that we're not supposed to merge changes to backport branches (though it's fine to make requests). The branch maintainer is given complete control over what lands. At least that's the policy last I checked. What's done is done though, and no point worrying about it. |
|
@maximecb Don't merge PR into |
|
I have reviewed the changeset. Also, if the changesets in the master branch cannot be cleanly applied, creating patches for the stable branches is always welcome. I will handle PRs when I am mentioned or assigned. |
This is a backported version of #8006
The patch is different because the two branches have diverged.
Original bug report: Shopify/yjit#313
YJIT: Fix autosplat miscomp for blocks with optionals
When passing an array as the sole argument to
yield, and the yieldee takes more than 1 optional parameter, the array is expanded similar to*arraysplat calls. This is called "autosplat" insetup_parameters_complex().Previously, YJIT did not detect this autosplat condition. It passed the array without expanding it, deviating from interpreter behavior. Detect this conditon and refuse to compile it.