Support --backtrace-limit in RUBYOPT, allow -1 as value, and add it to man page
#8010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomstuart
force-pushed
the
backtrace-limit-fixes
branch
from
ead51f6
to
0d4aaf8
Compare
tomstuart
force-pushed
the
backtrace-limit-fixes
branch
from
0d4aaf8
to
fc80297
Compare
There’s no reason to prevent RUBYOPT from controlling the backtrace limit. In fact, Matz said [0] he was expecting this to be possible. [0] https://bugs.ruby-lang.org/issues/8661#note-27
Co-authored-by: Tom Stuart <hi@tomstu.art>
-1 is a legitimate backtrace limit — in fact, it’s the default — so it should be possible to provide it with the `--backtrace-limit` option.
nobu
force-pushed
the
backtrace-limit-fixes
branch
from
fc80297
to
2bb617e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--backtrace-limitoption is not currently allowed to appear in theRUBYOPTenvironment variable, but that appears to be a mistake. Unlike other long options which are not allowed inRUBYOPT(e.g.--copyright,--version,--dumpand--help) it does not cause the interpreter to terminate, and cannot cause harm if read from the environment. During the initial discussion about the--backtrace-limitfeature, Matz suggested that he expectedRUBYOPTto allow this option.The
--backtrace-limitoption should also allow a value of -1 since that is legitimate (and the default), and be documented on Ruby’smanpage.