adding #round to Vector as well as Matrix

[jordanstephens]

It looks like @marcandre added #round to Matrix some years ago, but I would also like to be able to use this method with instances of Vector.

Because both Matrix and Vector both store their components in an underlying Array, and implement #map over that Array, I propose moving Matrix#round to Matrix::RoundHelper so that it may be included in both the Matrix and Vector classes and the functionality may be shared between them.

[marcandre]

Thanks for the PR.

Adding Vector#round sounds fine.

The helper isn't a bad idea (although I'm not sure why you defined a round_to instead of round directly), but since the implementation is really so simple, I'm not sure it's really necessary. I think it might be best to keep it duplicated, for example so the documentation works.

[jordanstephens]

I'm not sure why you defined a round_to instead of round directly

I actually did this to allow the method to be documented properly in each module. But if we think it's okay to have that bit of repeated code, we won't have to worry about that anymore.

I just pushed an amended commit.

Thanks @marcandre!

[jordanstephens]

@marcandre should I submit this to the ruby issue tracker over at https://bugs.ruby-lang.org ? Is there any hope of this getting merged from here on github?

[marcandre]

Awesome, thanks for the reminder.

[jordanstephens]

Awesome, thanks so much!