New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add yarp/yarp_compiler.c #8042
Merged
Merged
Add yarp/yarp_compiler.c #8042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM. @ko1 do you think it's OK for us to add |
2 points:
|
@ko1 I think renaming isn't a big deal, we just need to have a better name. Any suggestions? 😅 |
jemmaissroff
force-pushed
the
iseq-after-mirror
branch
3 times, most recently
from
July 14, 2023 14:44
5284899
to
1e3f31c
Compare
Please ask matz! |
I replied on https://bugs.ruby-lang.org/issues/19772.
|
jemmaissroff
force-pushed
the
iseq-after-mirror
branch
from
August 28, 2023 15:55
1e3f31c
to
3703449
Compare
This commit adds yarp/yarp_compiler.c, and changes the sync script to ensure that yarp/yarp_compiler.c will not get overwritten
jemmaissroff
force-pushed
the
iseq-after-mirror
branch
2 times, most recently
from
August 28, 2023 17:29
b400064
to
2137137
Compare
…yarp This commit creates the stencil for a compile_yarp function, which we will continue to fill out. It allows us to check the output of compiled YARP code against compiled code without using YARP.
jemmaissroff
force-pushed
the
iseq-after-mirror
branch
from
August 28, 2023 20:03
3696b43
to
147b797
Compare
kddnewton
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add structure code necessary for compiling YARP. I will continue to fill in the actual compilation code. This is just the stencil of how we'll implement
RubyVM::InstructionSequence.compile_yarp