New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YJIT: Compile exception handlers #8171
Conversation
9f0f25d
to
2ea3859
Compare
I think that the speedups are impressive. I'm a bit uncomfortable with the added complexity for entry points and interfacing with the interpreter though. This logic was already somewhat hard to follow. Needs clearer explanations in the comments and maybe a bit more streamlining if possible. |
e6a76b9
to
3d597e6
Compare
3d597e6
to
9b1b055
Compare
I reworked the callback in 9b1b055. It's still as complex as it needs to be, but at least it's much faster than the previous version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work 👍 I'm excited to see the results on SFR!
Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
This PR supports compiling exception handlers in YJIT.
ratio_in_yjit
This improves
ratio_in_yjit
, e.g.Benchmark
This speeds up liquid-render by 25%, liquid-compile by 6%, and sequel by 4%.
Other benchmarks don't seem to have a significant performance impact.