[DOC] Improve doc guide compliance #8221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peterzhu2118, why are we having more than one class/module defined in a file? It makes this operation (and perhaps others) more difficult. |
|
Some classes need to share internal implementation in the C code, so they live in the same file. Unfortunately we can't resolve this issue without some (possibly significant) refactors in the C code. |
object.c
Outdated
Comment on lines
4146
to
4148
| * These are the methods defined for BasicObject: | ||
| * | ||
| * - ::new: Returns a new \BasicObject instance. | ||
| * - ::new: Returns a new BasicObject instance. |
There was a problem hiding this comment.
This is documentation for the BasicObject class.
Co-authored-by: Peter Zhu <peter@peterzhu.ca>
peterzhu2118
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid suppressing autolinks to classes and modules.
I think this is the last for ruby/*.{c,rb}. Everything else is upstream, right?