Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Fix for RDoc for Process.kill #8370

Merged
merged 2 commits into from Sep 5, 2023
Merged

[DOC] Fix for RDoc for Process.kill #8370

merged 2 commits into from Sep 5, 2023

Conversation

BurdetteLamar
Copy link
Member

No description provided.

@BurdetteLamar BurdetteLamar added the Documentation Improvements to documentation. label Sep 5, 2023
* Use Signal.list to see which signals are supported, and the actual
* values.
*
* Additionally, signal +0+ is useful to determine if the process exists.
Copy link
Member

@nobu nobu Sep 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While Signal.list contains "EXIT"=>0 pair, its meaning differs in Process.kill.
We should keep this paragraph.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revised.

process.c Outdated
* values.
*
* Additionally, signal +0+ is useful to determine if the process exists.
* \Method <tt>Signal.list</tt> returns a hash of the string names
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signal.list will be linked to its document.

Suggested change
* \Method <tt>Signal.list</tt> returns a hash of the string names
* \Method Signal.list returns a hash of the string names

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@peterzhu2118 peterzhu2118 merged commit a17a1cd into ruby:master Sep 5, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements to documentation.
3 participants