[YARP] Use constant_id lookups where possible #8374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jemmaissroff
requested review from
kddnewton
and removed request for
kddnewton
jemmaissroff
force-pushed
the
yp-constant-lookups
branch
from
4951695
to
69b9db5
Compare
kddnewton
requested changes
Sep 5, 2023
yarp/yarp_compiler.c
Outdated
| @@ -359,6 +359,12 @@ yp_lookup_local_index_with_depth(rb_iseq_t *iseq, yp_compile_context_t *compile_ | |||
| return yp_lookup_local_index(iseq, compile_context, constant_id); | |||
| } | |||
|
|
|||
| static ID | |||
| yp_constant_id_lookup(yp_compile_context_t *compile_context, ID constant) | |||
There was a problem hiding this comment.
I don't think this will necessarily cause an issue because I think ID is an unsigned long long and yp_constant_id_t is a uint32_t so it will always be wider, but better to be safe than sorry.
Suggested change
| yp_constant_id_lookup(yp_compile_context_t *compile_context, ID constant) | |
| yp_constant_id_lookup(yp_compile_context_t *compile_context, yp_constant_id_t constant) |
Other than that, a comment on this function would be good just to explain what is being returned.
kddnewton
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.