Allow changing RUBY_PATCHLEVEL_STR if RUBY_PATCHLEVEL == -1 #8578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if RUBY_PATCHLEVEL == -1
byroot
approved these changes
Oct 2, 2023
I suspect you'll need quotes, |
nobu
reviewed
Oct 3, 2023
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
nobu
approved these changes
Oct 3, 2023
sorah
added a commit
to sorah/ruby
that referenced
this pull request
Nov 12, 2023
the regexp to replace RUBY_PATCHLEVEL_STR for prerelease snapshots doesn't match since rubyGH-8578. follow-up: ruby#8578 follow-up: 68df437
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of Shopify's services uses Ruby 3.3.0-preview2. So we use
ruby ">= 3.3.0.preview2"in Gemfile. We also want to deploy Ruby master (newer than preview2) to a few instances of that service, but 3.3.0.dev does not satisfy>= 3.3.0.preview2.I want to keep using
>= 3.3.0.preview2instead of relaxing it to>= 3.3.0.devsince I want to useruby ">= 3.3.0.preview3"when I bump it again. To allow installing Ruby master while keepingruby ">= 3.3.0.preview2", I'd like to changeRUBY_PATCHLEVEL_STRto something>= preview2, e.g.cppflags=-DRUBY_PATCHLEVEL_STR=pshopify1.