New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YJIT: Fix assert_no_exits #8579

Merged

k0kubun merged 1 commit into ruby:master from Shopify:yjit-no-exits

Oct 2, 2023

Member

k0kubun commented Oct 2, 2023

Currently, assert_no_exits tests nothing since exits.all? { |k, v| v === recorded_exits[k] } is true when exits is empty.

This PR changes it to also check their keys so that it will fail when exits is empty but recorded_exits is not.


          YJIT: Fix assert_no_exits

84ba7fb

matzbot requested a review from a team

October 2, 2023 20:25

maximecb approved these changes

View reviewed changes

k0kubun merged commit 492e943 into ruby:master

93 checks passed

k0kubun deleted the yjit-no-exits branch

October 2, 2023 21:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment