YJIT: Call mprotect after entry stub failure #8582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0kubun
force-pushed
the
yjit-entry-mark
branch
2 times, most recently
from
71ac83a
to
a704f1f
Compare
k0kubun
force-pushed
the
yjit-entry-mark
branch
from
a704f1f
to
f6eff14
Compare
maximecb
approved these changes
Oct 3, 2023
XrXr
approved these changes
Oct 3, 2023
Co-authored-by: Alan Wu <XrXr@users.noreply.github.com>
k0kubun
added a commit
to Shopify/ruby
that referenced
this pull request
Oct 10, 2023
Co-authored-by: Alan Wu <XrXr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
entry_stub_hitruns out of memory, it currently doesn't callmark_all_executable(aftercode_gc). It causes SEGV.This PR fixes that issue by removing an early return and let the failure case go through the same flow and return at the end.