[PRISM] Fix more bugs in the compiler #8658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jemmaissroff
commented
Oct 13, 2023
jemmaissroff
commented
- Fixes ConstantPathWriteNode
- Fixes FlipFlopNode
kddnewton
approved these changes
Oct 13, 2023
| PM_COMPILE(constant_path_write_node->value); | ||
| PM_DUP_UNLESS_POPPED; | ||
|
|
||
| ID constant_var_name = parse_location_symbol(&constant_path_write_node->target->base.location); |
There was a problem hiding this comment.
Can we get rid of this method now?
kddnewton
reviewed
Oct 13, 2023
test/ruby/test_compile_prism.rb
Outdated
| @@ -167,7 +167,8 @@ def test_ConstantPathTargetNode | |||
| end | |||
|
|
|||
| def test_ConstantPathWriteNode | |||
| # test_prism_eval("Prism::YCT = 1") | |||
| test_prism_eval("Prism::ConstantPathWriteNode= 1") | |||
There was a problem hiding this comment.
I would make this PCT otherwise it's going to conflict when they run the tests more than once.
And for below ::Prism::PCT
jemmaissroff
force-pushed
the
compile-bugs
branch
from
a4173d1
to
31d7c46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.