YJIT: Use RbConfig.ruby instead of EnvUtil.rubybin #8689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some people encounter an issue that test_yjit uses the installed Ruby instead of the currently-running Ruby. It's fixed when they remove the installed Ruby. However, test_yjit should run the currently-running Ruby for testing YJIT in subprocesses. EnvUtil is unfortunately used outside tests as well, so for compatibility reasons, this commit only changes the argument given to EnvUtil.invoke_ruby to always use RbConfig.ruby.
XrXr
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Sounds good to me. By the way, I dug a little bit after looking at the logic in EnvUtil.invoke_ruby and it was actually using RUBY=build_dir/exe/ruby from the environment set by runruby.rb, and make test-all only builds ruby, but doesn't copy it over to exe/ruby.
Co-authored-by: Alan Wu <XrXr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EnvUtil.invoke_rubyusesEnvUtil.rubybinby default, which has a weird fallback logic that is not necessary for test_yjit.Since there are folks reporting test_yjit failures we can't reproduce, I want to rule out that possibility by always using
RbConfig.ruby.