Optimize unicode_normalize methods #8966
Open
+3,999
−3,978
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes several changes to the implementation of the internal
UnicodeNormalize
module to improve performance and reduce memory allocations.String#ascii_only?
is extremely fast and helps in cases when user tries to normalize ASCII-only strings (for example, this helps to save a lot of time and memory in the IDNA mapping from UTS46 which I want to propose as a default IDNA algorithm to ruby/uri, but that's a different story 😅)map
+join
->each
,gsub
->gsub!
)Benchmark
Benchmark is kinda spoiled by the usage of cache, but still 😅
Macbook 13", M1, 2020, 16 GB, Ruby 3.2.2
Memory profiling: