Get the error codes as Socket::EAI_XXX when getaddrinfo and getnameinfo fail
#9018
+44
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shioimm
added a commit
to shioimm/net-ftp
that referenced
this pull request
Nov 23, 2023
The following PR changes cause Socket::ResolutionError, a subclass of SocketError, to be raised in this test case. ruby/ruby#9018 While `assert_raise` verifies that the error being raised is indeed a SocketError, `assert_raises` can verify that it is a SocketError or a subclass thereof. It will avoid unwanted test failures.
shioimm
force-pushed
the
add-resolution_error
branch
from
98a1f18
to
62b3965
Compare
Socket::ResolutionError#error_code returns Socket::EAI_XXX
…t_error rsock_raise_socket_error is called only when getaddrinfo and getaddrname fail
Again, rsock_raise_socket_error is called only when getaddrinfo and getaddrname fail
shioimm
force-pushed
the
add-resolution_error
branch
from
62b3965
to
b95f03c
Compare
shioimm
added a commit
to shioimm/net-ftp
that referenced
this pull request
Nov 29, 2023
The following PR changes cause Socket::ResolutionError, a subclass of SocketError, to be raised in this test case. ruby/ruby#9018 In this repository, make it fall back to SocketError if it is not defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows getting the error codes as
Socket::EAI_XXXwhengetaddrinfoandgetnameinfofail.The purpose of this PR
This PR is necessary to implement Happy Eyeballs version 2 (RFC 8305) in
Socket.tcp.In HEv2,
EAI_ADDRFAMILYandEAI_AGAINobtained during name resolution should be ignored. However, there is currently no way to askSocketErrorfor errors returned bygetaddrinfo, so I opened this PR.Changes
Socket::ResolutionErroras a subclass ofSocketErrorSocketError(rb_eSocket) withSocket::ResolutionError(rb_eResolutionError) inrsock_raise_socket_errorbecause this function is only called whengetaddrinfoandgetnameinfofailrsock_raise_socket_errortorock_raise_resolution_errorfor the same reasonNote
Socket::ResolutionError is a subclass of SocketError, so it does not affect
rescue SocketErrorin source codes.