Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting for padding argument in Base64#urlsafe_encode64 #905

Closed
wants to merge 1 commit into from
Closed

Fix formatting for padding argument in Base64#urlsafe_encode64 #905

wants to merge 1 commit into from

Conversation

davydovanton
Copy link
Contributor

No description provided.

@mame
Copy link
Member

mame commented May 20, 2015

Looks good to me. I'd like to import the pull request to Ruby SVN trunk, but I don't know the workflow to do so. Any one could tell me?

@davydovanton
Copy link
Contributor Author

@mame I don't know too 😓
But I think that you need pull my commit and after that push this to ruby svn trunk branch like this

@davydovanton
Copy link
Contributor Author

So I am sure that @zzak or @hsbt will help 😃

@mame
Copy link
Member

mame commented May 20, 2015

Thanks, actually @hsbt is now helping me on IRC :-)

@davydovanton
Copy link
Contributor Author

super! 👏

@mame mame closed this in 7fc7651 May 20, 2015
@mame
Copy link
Member

mame commented May 20, 2015

Great. Thank you @davydovanton !

@davydovanton
Copy link
Contributor Author

thanks! 🌟

@davydovanton davydovanton deleted the fix-code-text branch May 20, 2015 14:28
nurse pushed a commit to nurse/ruby that referenced this pull request May 25, 2015
  [fix rubyGH-905][ci skip] Patch by @davydovanton

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50560 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
mmasaki pushed a commit to mmasaki/ruby that referenced this pull request May 30, 2015
  [fix rubyGH-905][ci skip] Patch by @davydovanton

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50560 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants