Add missing GVL hooks for M:N threads and ractors #9073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byroot
approved these changes
Nov 30, 2023
|
I think the CI errors may be legit though? Something Ractor related, not super clear, but too consistent to just be a flake |
[Bug #20019] This fixes GVL instrumentation in three locations it was missing: - Suspending when blocking on a Ractor - Suspending when doing a coroutine transfer from an M:N thread - Resuming after an M:N thread starts Co-authored-by: Matthew Draper <matthew@trebex.net>
jhawthorn
force-pushed
the
fix-gvl-instrumentation-missing-events
branch
from
d49573a
to
6f001b3
Compare
|
The errors were legit, I think I figured it out. I need to do a bit of a dance to do tests using Ractors without breaking later tests. |
|
The two remaining errors were flakes, they passed on a retry.
|
|
Thanks for reverting this PR's commit on #9108. I see this PR triggered a random test failure. So, please run CI a few times next time to avoid it. |
This was referenced Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup: #9050
This fixes GVL instrumentation in three locations it was missing related to M:N threads and Ractors:
cc @jpcamara @byroot @ko1 @tenderlove